fix(label): update label min-width to match height#7217
fix(label): update label min-width to match height#7217mcoker merged 1 commit intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-pr-7217.surge.sh A11y report: https://patternfly-pr-7217-a11y.surge.sh |
There was a problem hiding this comment.
This is fine, but I do wonder if we really ever want them to be narrower than they are tall? (ie a circle?) Maybe something to ask design and circle back on 😆
I reached out to Andrew and Lucia and got the thumbs up to maintain a I will update this pr to handle these changes. |
ad1ae18 to
8d1039d
Compare
8d1039d to
32b228d
Compare
| --#{$label}--m-compact--PaddingInlineStart: var(--pf-t--global--spacer--sm); | ||
| --#{$label}--m-compact--FontSize: var(--pf-t--global--font--size--body--sm); | ||
| --#{$label}--m-compact--m-editable--TextUnderlineOffset: #{pf-size-prem(1px)}; | ||
| --#{$label}--m-compact--MinWidth: calc(var(--#{$label}--m-compact--FontSize) * var(--pf-t--global--font--line-height--body)); |
There was a problem hiding this comment.
Should compact use the same formula, adding on the block paddings just in case someone adjusts those variables to something other than zero?
32b228d to
433fe6c
Compare
433fe6c to
e2f4467
Compare
|
🎉 This PR is included in version 6.1.0-prerelease.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #7215
Set label
min-widthto equal height