8000 feat(title/content): add page title variation by mcoker · Pull Request #7212 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

feat(title/content): add page title variation#7212

Merged
mcoker merged 3 commits intopatternfly:mainfrom
mcoker:issue-7072
Nov 14, 2024
Merged

feat(title/content): add page title variation#7212
mcoker merged 3 commits intopatternfly:mainfrom
mcoker:issue-7072

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Nov 11, 2024 •
edited
Loading

fixes #7072

  • Adds .pf-m-page-title to the content component and title component
  • Can be applied to any heading level/size and it will override the font-weight
  • Updates our standard full-page demo template to add the page title modifier to the main heading
    • Some demos may not use that template and would need to be updated manually
    • We could add the page-title modifier to the "Hello world" heading in main content component examples - wdyt @lboehling @andrew-ronaldson?

Links:
https://patternfly-pr-7212.surge.sh/components/content
https://patternfly-pr-7212.surge.sh/components/title#page-title
https://patternfly-pr-7212.surge.sh/components/page/html-demos/basic/
https://patternfly-pr-7212.surge.sh/components/data-list/html-demos/basic/

@patternfly-build
Copy link
Collaborator
patternfly-build commented Nov 11, 2024 •
edited
Loading

Preview: https://patternfly-pr-7212.surge.sh

A11y report: https://patternfly-pr-7212-a11y.surge.sh

@mcoker mcoker requested a review from srambach November 12, 2024 00:03
srambach
srambach approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will we want an org followup to apply/clean up the page titles?

@mcoker
Copy link
Contributor Author
mcoker commented Nov 14, 2024

@srambach I reckon so! I'd defer to @lboehling since she understands the usage requirements better than I do.

lboehling
lboehling approved these changes Nov 14, 2024
View reviewed changes
Copy link
@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you, @mcoker 🤩 I think adding it to the "Hello world" title in the example makes sense. I also +1 for a follow-up issue to make sure the styles on the org are cleaned up/updated.

@mcoker mcoker requested review from lboehling and srambach November 14, 2024 21:35
lboehling
lboehling approved these changes Nov 14, 2024
View reviewed changes
Copy link
@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@mcoker mcoker merged commit 4b5841c into patternfly:main Nov 14, 2024
@patternfly-build
Copy link
Collaborator
patternfly-build commented Nov 19, 2024

🎉 This PR is included in version 6.1.0-prerelease.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker mentioned this pull request Dec 5, 2024
Merged
@mcoker mcoker deleted the issue-7072 branch January 7, 2025 16:58
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lboehling lboehling lboehling approved these changes

@andrew-ronaldson andrew-ronaldson Awaiting requested review from andrew-ronaldson

@srambach srambach Awaiting requested review from srambach

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DPO Typography Updates -- Content/Title Component updates?

4 participants

@mcoker @patternfly-build @srambach @lboehling
0