fix(data-list): add spacing to compact data-list buttons#7189
fix(data-list): add spacing to compact data-list buttons#7189mcoker merged 1 commit intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-pr-7189.surge.sh A11y report: https://patternfly-pr-7189-a11y.surge.sh |
There was a problem hiding this comment.
LGTM!! Can you also update the actions in this example to use the small variation? https://patternfly-pr-7189.surge.sh/components/data-list/html/expandable-compact/
One other thing, I love the hbs data-list--IsCompact parameter - totally optional or could be a follow up, but it would be great if that could set .pf-m-compact as well. Otherwise it's a little confusing that a .pf-m-compact data-list also needs data-list--IsCompact to attempt to resize its buttons. As far as I can tell there are only 4 compact data lists in our docs that would need to be updated.
| {{> @partial-block}} | ||
| {{else}} | ||
| {{> menu-toggle | ||
| menu-toggle--IsSmall=data-list--IsCompact |
355dc77 to
c36096a
Compare
|
@sg00dwin can you rebase this branch to see if it resolves the build error? |
c36096a to
0eddc7b
Compare
|
🎉 This PR is included in version 6.1.0-prerelease.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #7105
Backstop tests
https://drive.google.com/drive/folders/1aKh3N42bPbMjsfkTTbGOrQr8zUO_YHYn?usp=sharing
Before
After
Before
After
