fix(menu): enable menu items with favorites to show star icon and set icon color when favorited#7184
Conversation
|
Preview: https://patternfly-pr-7184.surge.sh A11y report: https://patternfly-pr-7184-a11y.surge.sh |
| @@ -2,19 +2,18 @@ | |||
| {{setModifiers | |||
| menu-list-item--IsAriaDisabled='pf-m-aria-disabled' | |||
| menu-item-action--IsFavorite='pf-m-favorite' | |||
There was a problem hiding this comment.
Can this line be removed? It looks like menu-item-action--IsFavorite is used in the .hbs to create the icon, but we don't have .pf-m-favorite in menu.scss (Unless this is only used in react? The usage section says "Modifies the menu item action to handle the favorite icon.")
There was a problem hiding this comment.
I believe you are correct, so I'll remove.
Though I did find pf-m-favorite referenced in the react component, but I don't see it utilizing any styling.
… icon color gold when favorited
b89f83f to
39735eb
Compare
There was a problem hiding this comment.
Looks ⭐ !
Do you want to create a React followup to remove that class from the React component?
New issue created patternfly/patternfly-react#11176 |
There was a problem hiding this comment.
LGTM! I have a couple of small ideas as follow ups but they aren't blocking so I'll create a new issue to track those.
|
🎉 This PR is included in version 6.1.0-prerelease.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #7180
https://patternfly-pr-7184.surge.sh/components/menus/menu#with-favorites