fix(table-text): updated truncate value#7175
Merged
mcoker merged 2 commits intopatternfly:mainfrom Nov 21, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-7175.surge.sh A11y report: https://patternfly-pr-7175-a11y.surge.sh |
srambach
reviewed
Oct 31, 2024
Member
There was a problem hiding this comment.
I like this change. I'm wondering if this example needs some love though? It looks like it's lost its space between the two columns.
nicolethoen
approved these changes
Nov 6, 2024
mcoker
requested changes
Nov 6, 2024
Contributor
There was a problem hiding this comment.
Doesn't appear to be working in the preview?
595f49f to
c7c716e
Compare
c7c716e to
8e4be38
Compare
8e4be38 to
d05f4fe
Compare
srambach
approved these changes
Nov 21, 2024
Member
There was a problem hiding this comment.
Looks like it's working as expected now.
Collaborator
|
🎉 This PR is included in version 6.1.0-prerelease.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7172
TLDR:
max(var(--#{$table}--m-truncate__text--MinWidth), var(--#{$table}--m-truncate--cell--MaxWidth));setstable__text.m-truncateto accept larger of the two values, assuring that truncated text is always at least5chlong and at max100%.Link: https://patternfly-pr-7175.surge.sh/components/table
BackstopJS Report table text.pdf