fix(table): reduce max-width breakpoints 1px#7171
Merged
mcoker merged 2 commits intopatternfly:mainfrom Nov 6, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-7171.surge.sh A11y report: https://patternfly-pr-7171-a11y.surge.sh |
Collaborator
|
🎉 This PR is included in version 6.1.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7139
This PR fixes the issue of
max-widthbreakpoints (currently only used in Table component) overlapping the more standardmin-widthbreakpoints by 1px at the very top of the width by creating a new function to subtract 1px from the max-width.To test use Hidden/visible breakpoint modifiers example and size screen width from 991 => 992 => 993px.
Current behavior - columns hide/show correctly at 992px layout does not update until 993px
Screen.Recording.2024-10-23.at.11.18.04.AM.mov
Fixed behavior - columns continue to hide/show correctly but layout also updates at 992px (no changes at 993px)
Screen.Recording.2024-10-23.at.11.19.06.AM.mov