8000 fix(page): apply bottom padding to page breadcrumb and horizontal subnav elements by sg00dwin · Pull Request #7152 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

fix(page): apply bottom padding to page breadcrumb and horizontal subnav elements#7152

Merged
mcoker merged 1 commit intopatternfly:mainfrom
sg00dwin:7104-labelgroup
Oct 30, 2024
Merged

fix(page): apply bottom padding to page breadcrumb and horizontal subnav elements#7152
mcoker merged 1 commit intopatternfly:mainfrom
sg00dwin:7104-labelgroup

Conversation

@sg00dwin
Copy link
Contributor
@sg00dwin sg00dwin commented Oct 17, 2024

fixes #7145

Convenience links:

After
Screenshot 2024-10-17 at 3 04 05 PM

Screenshot 2024-10-17 at 3 05 00 PM

@patternfly-build
Copy link
Collaborator
patternfly-build commented Oct 17, 2024

Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM!

@andrew-ronaldson
Copy link
Collaborator

Knocked it out of the park ⚾️

@sg00dwin sg00dwin force-pushed the 7104-labelgroup branch 2 times, most recently from 391612b to 4758194 Compare October 24, 2024 20:26
@mattnolting mattnolting self-requested a review October 30, 2024 16:04
Copy link
Collaborator
@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM 👍

@mcoker mcoker merged commit 6ea3bbb into patternfly:main Oct 30, 2024
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.1.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Page: Sticky breadcrumb needs a spacer for padding-block-end

5 participants

0