Conversation
|
Preview: https://patternfly-pr-7149.surge.sh A11y report: https://patternfly-pr-7149-a11y.surge.sh |
|
|
||
| // Tooltip | ||
| --#{$chart}-tooltip--corner-radius: 0; | ||
| --#{$chart}-tooltip--corner-radius: 6; |
There was a problem hiding this comment.
Not sure if you have a good way to do this on the react side, but I wonder if you could use the --pf-t--global--border--radius--small token here (and for --#{$chart}-tooltip--flyoutStyle--corner-radius below), and strip the unit in react-charts when you reference chart_tooltip_corner_radius.value and chart_tooltip_flyoutStyle_corner_radius.value?
FWIW, here's the tooltip style that references that same token
There was a problem hiding this comment.
I don't think it's a good idea to include units here. This introduces a mix of numbers and strings in react-tokens, which is confusing because Victory can't use units. Not only would we need to strip the units, but anyone creating a custom tooltip would likely need to do the same.
|
🎉 This PR is included in version 6.0.0-prerelease.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Charts should have rounded corners for PF v6
Fixes #7148