chore(menu-toggle): remove reference to pf-m-action#7136
Merged
mcoker merged 3 commits intopatternfly:mainfrom Nov 6, 2024
Merged
chore(menu-toggle): remove reference to pf-m-action#7136mcoker merged 3 commits intopatternfly:mainfrom
mcoker merged 3 commits intopatternfly:mainfrom
Conversation
Collaborator
|
Preview: https://patternfly-pr-7136.surge.sh A11y report: https://patternfly-pr-7136-a11y.surge.sh |
mcoker
approved these changes
Oct 3, 2024
Contributor
There was a problem hiding this comment.
LGTM! As part of this, we should probably also:
- Remove the use of
menu-toggle--IsActionsince that no longer does anything - Rename and clean up the split toggle examples since a lot of them reference "action" if they were a
.pf-m-action-specific toggle
Any interest in doing that here? If not we can create a follow-up.
Collaborator
|
🎉 This PR is included in version 6.1.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We removed
pf-m-actionfrom the menu toggle but missed removing it from the hbs and docs, so this cleans that up.Fixes #7135