fix(table): fixed thead checkbox fitting#7134
Conversation
|
Preview: https://patternfly-pr-7134.surge.sh A11y report: https://patternfly-pr-7134-a11y.surge.sh |
| --#{$table}--cell--MinWidth: 0; | ||
| --#{$table}--cell--Width: 1%; | ||
|
|
||
| max-width: none; |
There was a problem hiding this comment.
WDYT about using something like fit-content or min-content? I'm not sure it's any different functionally but worries me less 🙃
There was a problem hiding this comment.
Looks like "fit-content" doesn't work in FF, though "none" does
There was a problem hiding this comment.
The checkbox isn't visible at all in FF, though FWIW that was pre-existing. If there are no concerns with using max-width: none, it looks like that works in FF, too.
3c59dc4 to
59ebbaa
Compare
|
@mcoker updated |
|
BackstopJS Report for |
| --#{$table}--cell--MinWidth: 0; | ||
| --#{$table}--cell--Width: 1%; | ||
|
|
||
| max-width: none; |
|
🎉 This PR is included in version 6.1.0-prerelease.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #7132
TLDR:
table__checkcells are supposed to be set asmax-width: none. In this case,max-widthis being overridden by.pf-v6-c-table tr:where(.pf-v6-c-table__tr) > :where(th, td)Convenience links:
https://patternfly-pr-7134.surge.sh/components/table/html-demos/loading-state-demo/
https://patternfly-pr-7134.surge.sh/components/table/html-demos/empty-state/