fix(datalist): adjust action elements, spacing#7089
Merged
mcoker merged 3 commits intopatternfly:mainfrom Sep 23, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-7089.surge.sh A11y report: https://patternfly-pr-7089-a11y.surge.sh |
tlabaj
reviewed
Sep 20, 2024
Contributor
There was a problem hiding this comment.
do you need to remove the <div class="pf-v6-c-data-list__action"> wrapper from the examples?
Contributor
Author
|
@tlabaj d'oh! Yep, forgot to update the handlebars to remove that element. Updated 👍 |
Contributor
There was a problem hiding this comment.
There's some usage of the removed data-list-action component in some of the examples in the markdown file, otherwsie lgtm
Contributor
Author
|
@thatblindgeye thanks! Updated 🚀 |
thatblindgeye
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7079
This removes
__action, which was only used to wrap plain actions and give them a negative top/bottom margin, and adds that negative offset to__item-actionso it will apply to all actions. Got design approval for the change in patternfly/patternfly-react#10939 (comment)