fix(content): actually remove root, update content selector#7074
fix(content): actually remove root, update content selector#7074mcoker merged 2 commits intopatternfly:mainfrom
Conversation
| {{> @partial-block newcontext}} | ||
| {{> @partial-block content--element--IsPlain=reset}} |
There was a problem hiding this comment.
Lets context pass (particularly interested in content--element--IsEditorial) but resets content--element--IsPlain, which doesn't need to pass through - it's just used for lists.
|
Preview: https://patternfly-pr-7074.surge.sh A11y report: https://patternfly-pr-7074-a11y.surge.sh |
| @use '../../sass-utilities' as *; | ||
|
|
||
| @include pf-root($content) { | ||
| @include pf-root(':root', false) { |
There was a problem hiding this comment.
Since we support .pf-v6-c-content--[all content elements] as a standalone class, outside of .pf-v6-c-content now, these vars need to be accessible outside of .pf-v6-c-content. Originally I had changed this to [class*="pf-v6-c-content"] but that won't work with user overrides since we'll be resetting the variables for each of those classes. So maybe content can be an exception and continue to scope its vars to :root?
|
🎉 This PR is included in version 6.0.0-prerelease.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Looks like I forgot to commit removing
:rootin #7060 🤦♂️ And there was an update to the content component I was still working out, so made that, too.Here's the backstop report. From what I can tell, everything is a false positive or related to previous updates.