fix(page): adjust main container and sidebar scrollbars#7068
fix(page): adjust main container and sidebar scrollbars#7068mcoker merged 2 commits intopatternfly:mainfrom
Conversation
|
Preview: https://patternfly-pr-7068.surge.sh A11y report: https://patternfly-pr-7068-a11y.surge.sh |
There was a problem hiding this comment.
I checked this in Chrome, firefox and Safari. Safari is the only one that keeps the scrollbar background-color. Would this ::-webkit-scrollbar-track: work to tackle the safari issue.
Other than that I think this looks great and Safari is a lower priority browser
|
@andrew-ronaldson yep, the controls for safari scrollbar colors are a little different, and seem to be finicky? Here's a codepen with the overrides in it. https://codepen.io/mcoker/pen/LYKvOgW You can see in safari that the sidebar scrollbar styles are working, but not on the page main container. If we update the Also, I'm assuming if we were to introduce custom scrollbar styles, we would do it for all scrollbars - not just the sidebar/page container? I went ahead and took out the scrollbar changes from this PR - wdyt about merging these changes and following up on the scrollbar stuff, either for final or post-v6, but that would let us get these other changes in now. |
There was a problem hiding this comment.
Would this go towards #6834 at all, too?
There was a problem hiding this comment.
This looks good in the main container. The floating track next to the nav feels awkward but can be addressed your followup issue. Thanks!
There was a problem hiding this comment.
📜 Looks good, nice work with design
towards patternfly/patternfly-design#1315