8000 chore(backstop): update screenshots by mcoker · Pull Request #7062 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

chore(backstop): update screenshots#7062

Merged
mcoker merged 1 commit intopatternfly:mainfrom
mcoker:backstop-9-11-24
Sep 11, 2024
Merged

chore(backstop): update screenshots#7062
mcoker merged 1 commit intopatternfly:mainfrom
mcoker:backstop-9-11-24

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Sep 11, 2024 •
edited
Loading

Backstop report - backstop-9.11.24.pdf

Reasons for failures:

  • There is a sub-pixel shift in input groups with a control button, result of adding min-width to the base button component.
  • Form control icon spacing is from semantic gap spacer updates
  • Form sections - the gap between label/control pairs in sections was updated to match the gap on the base form when the pairs are not in a section
  • Dual list selector - gap between the arrow plain actions in the middle was updated
  • Description list
    • Column gap between dt/dd pairs was updated
    • Column gap between dt and dd in horizontal layout was updated
  • Copy to clipboard - gap between actions was updated
  • Card actions - gap between actions was updated
  • Accordion - space between toggle icon and text was updated to use text-to-element spacer
  • Form - inline control group (like radios/checkboxes in a horizontal row) gap was updated

@patternfly-build
Copy link
Collaborator
patternfly-build commented Sep 11, 2024 •
edited
Loading

Preview: https://patternfly-pr-7062.surge.sh

A11y report: https://patternfly-pr-7062-a11y.surge.sh

evwilkin
evwilkin approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member
@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on your summary of changes in issue description - everything flagged looks to map back to those updates 👍

@mcoker mcoker merged commit 5c703ad into patternfly:main Sep 11, 2024
@patternfly-build
Copy link
Collaborator
patternfly-build commented Sep 12, 2024

🎉 This PR is included in version 6.0.0-prerelease.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker deleted the backstop-9-11-24 branch January 7, 2025 16:49
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evwilkin evwilkin evwilkin approved these changes

@mattnolting mattnolting Awaiting requested review from mattnolting

@thatblindgeye thatblindgeye Awaiting requested review from thatblindgeye

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcoker @patternfly-build @evwilkin
0