fix(expandable-section): adjust styles, icon, update screenshots#7006
Merged
mattnolting merged 3 commits intopatternfly:v6from Aug 28, 2024
Merged
fix(expandable-section): adjust styles, icon, update screenshots#7006mattnolting merged 3 commits intopatternfly:v6from
mattnolting merged 3 commits intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-7006.surge.sh A11y report: https://patternfly-pr-7006-a11y.surge.sh |
| {{{multiple-file-upload-status-progress-icon--attribute}}} | ||
| {{/if}}> | ||
| <i class="pf-v6-pficon pf-v6-pficon-in-progress"></i> | ||
| {{! <i class="pf-v6-pficon pf-v6-pficon-in-progress"></i> }} |
Contributor
There was a problem hiding this comment.
Did we want to keep this comment to revert back to this element in the future?
Contributor
Author
There was a problem hiding this comment.
@thatblindgeye yep, though I just updated the comment to add TODO text that describes why it's commented.
thatblindgeye
approved these changes
Aug 28, 2024
mattnolting
approved these changes
Aug 28, 2024
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.226 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7007
I was updating the backstop screenshots and noticed these issues with multiple file upload/expandable section. This PR
align-items: starton expandable section to allow both the toggle and content elements to occupy the width of their container