feat(progress): display progress measure as tabular numbers#6985
Merged
mcoker merged 1 commit intopatternfly:v6from Aug 20, 2024
Merged
feat(progress): display progress measure as tabular numbers#6985mcoker merged 1 commit intopatternfly:v6from
mcoker merged 1 commit intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6985.surge.sh A11y report: https://patternfly-pr-6985-a11y.surge.sh |
Member
Author
|
@lboehling @andrew-ronaldson Just want to call out that this modifies all the "measure" numbers shown on a progress bar. If you'd prefer that it only affects those with static width measure or some other subset, please let me know. |
Contributor
|
Tabular numbers will go in these places: When inside the progress bar The "Step 2..." text 33% text "2 of 5" text 33% |
mcoker
approved these changes
Aug 16, 2024
Contributor
There was a problem hiding this comment.
LGTM as long as the places that were updated are where design intended 👍
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.221 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should take care of the only issue not addressed in another issue on #5476
This PR changes the progress measure to be tabular numbers.