fix(notification-badge): removed component, updated hbs partial#6983
Merged
mattnolting merged 1 commit intopatternfly:v6from Aug 16, 2024
Merged
fix(notification-badge): removed component, updated hbs partial#6983mattnolting merged 1 commit intopatternfly:v6from
mattnolting merged 1 commit intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6983.surge.sh A11y report: https://patternfly-pr-6983-a11y.surge.sh |
thatblindgeye
approved these changes
Aug 16, 2024
Contributor
There was a problem hiding this comment.
LGTM. Not a blocker since like mentioned we can revisit, but since it looks like the notification badge is only being called in one masthead hbs file, updating the file/component name to something like a "button--stateful" or "button--notification-badge" template would work with minimal update.
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.214 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6238
Moves the old notification-badge.hbs to the button component and updates the logic, so no examples needed to be updated. We can always update that at some point if it's confusing.
Backstop report - the majority of this is a padding update to plain menu toggles, and other content around the toggles shifting slightly. It also includes the logo updates @rebeccaalpert made. If you scroll to the notification drawer examples, you'll see the notification badge update. If this report looks good, I'll add the screenshots to the PR.