feat(nav): style drilldown menu for nav#6982
Conversation
|
Preview: https://patternfly-pr-6982.surge.sh A11y report: https://patternfly-pr-6982-a11y.surge.sh |
There was a problem hiding this comment.
Nice! LGTM, just some nit comments.
| --#{$menu}__list-item--hover--BackgroundColor: var(--#{$nav}__link--hover--BackgroundColor); | ||
| --#{$menu}__list-item--hover--BackgroundColor: transparent; |
There was a problem hiding this comment.
Looks like this one is duped
| &:hover, | ||
| &:focus { | ||
| --#{$menu}__item--BackgroundColor: var(--#{$nav}__link--hover--BackgroundColor); | ||
| } |
There was a problem hiding this comment.
Curious if we could remove this and get the same with --pf-v6-c-menu__list-item--hover--BackgroundColor: var(--pf-v6-c-nav__link--hover--BackgroundColor); in the &.pf-m-drilldown above? We would then want to update the border-radius so it goes on .pf-v6-c-menu__list-item and .pf-v6-c-menu__list-item::before (or maybe just .pf-v6-c-menu__list-item::before if that works?) and clean up the existing item/list-item background vars on &.pf-m-drilldown
| --#{$menu}__item--BackgroundColor: var(--#{$nav}__link--BackgroundColor); | ||
|
|
||
| .#{$menu}__list { | ||
| gap: var(--#{$nav}__subnav--RowGap); |
There was a problem hiding this comment.
Just so we don't need to change this if we ended up adding a column-gap for some reason
| gap: var(--#{$nav}__subnav--RowGap); | |
| row-gap: var(--#{$nav}__subnav--RowGap); |
|
🎉 This PR is included in version 6.0.0-alpha.216 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixes #6919