Conversation
|
Preview: https://patternfly-pr-6981.surge.sh A11y report: https://patternfly-pr-6981-a11y.surge.sh |
There was a problem hiding this comment.
looks great, thank u!! left one suggestion re: the on-disabled tick color.
| --#{$slider}__step-tick--Width: 0.15rem; | ||
| --#{$slider}__step-tick--Height: #{pf-size-prem(4px)}; | ||
| --#{$slider}__step-tick--BackgroundColor: var(--pf-t--global--icon--color--subtle); | ||
| --#{$slider}__step-tick--BackgroundColor: var(--pf-t--global--icon--color--on-disabled); |
There was a problem hiding this comment.
now that i'm thinking about this more, we should probably use --pf-t--global--icon--color--nonstatus--on-gray--default here. It will still look darker than the design screenshot in the issue (I didn't update the tick color token in the screenshot!).
There was a problem hiding this comment.
There was a problem hiding this comment.
Not necessarily a blocker, but for the "Actions" example, is the slider itself meant to be disabled along with the input? Second Slider in the below screenshot. Otherwise lgtm
|
@thatblindgeye nice catch! Looking at what's in v5 for react as how that should behave, looks like the slider and value input are disabled when the action is set to the lock. Updated that example to disable the slider. |
There was a problem hiding this comment.
perfect!! thanks for the quick work on this!!
|
🎉 This PR is included in version 6.0.0-alpha.215 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #6977 and pulls in the latest tokens from patternfly/design-tokens#82
@lboehling the only difference I see in the between what's in the PR and in the referenced issue is the disabled/unfilled tick color (updated to
--pf-t--global--icon--color--on-disabled). In the design screenshot, the tick color is lighter than the background, but--pf-t--global--icon--color--on-disabledis a darker color. Not sure if anything needs to be updated there?