8000 feat(motion): replace old local animation tokens with new motion tokens by srambach · Pull Request #6961 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

feat(motion): replace old local animation tokens with new motion tokens#6961

Merged
mcoker merged 4 commits intopatternfly:v6from
srambach:6936-old-transitions
Aug 30, 2024
Merged

feat(motion): replace old local animation tokens with new motion tokens#6961
mcoker merged 4 commits intopatternfly:v6from
srambach:6936-old-transitions

Conversation

@srambach
Copy link
Member
@srambach srambach commented Aug 12, 2024

This removes the old local tokens for animation and replaces them with motion tokens.

There is a follow-on issue to replace hard-coded transitions with tokens.

I've also put a TODO in sidebar and drilldown menu because we need to add a default for prefers-reduced-motion since these two are using a slide.

Fixes #6936

@patternfly-build
Copy link
Collaborator
patternfly-build commented Aug 12, 2024

@srambach srambach linked an issue Aug 12, 2024 that may be closed by this pull request
Copy link
@kaylachumley kaylachumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator
@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates look great! I'm noticing that page and wizard transitions don't seem to have an affect. Are you seeing the same?

@srambach
Copy link
Member Author

These updates look great! I'm noticing that page and wizard transitions don't seem to have an affect. Are you seeing the same?

I see the sidebar slide on the page, and on the wizard, the caret rotates. Those are the only ones on those components, right? What are you expecting to see?

@mattnolting
Copy link
Collaborator

I see the sidebar slide on the page, and on the wizard, the caret rotates. Those are the only ones on those components, right? What are you expecting to see?

I was looking for the sidebar itself to transition, which is the wrong thing to be looking at 😆

@mattnolting mattnolting self-requested a review August 29, 2024 19:09
Copy link
Collaborator
@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, looks great! 🎉

8000
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦧🍌

@mcoker mcoker merged commit aa31c48 into patternfly:v6 Aug 30, 2024
@mcoker mcoker mentioned this pull request Aug 30, 2024
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.231 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free 7C39 to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up old transitions

5 participants

0