feat(Table): add padding except for clickable expandable rows#6958
Merged
mcoker merged 2 commits intopatternfly:v6from Aug 20, 2024
Merged
feat(Table): add padding except for clickable expandable rows#6958mcoker merged 2 commits intopatternfly:v6from
mcoker merged 2 commits intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6958.surge.sh A11y report: https://patternfly-pr-6958-a11y.surge.sh |
Contributor
Author
|
Visual regression ran fine locally, just minor icon pixel differences (I think because Chromium is a different installation - Intel chip vs. ARM chip) and one test where the screenshot was taken before the icons loaded. |
srambach
approved these changes
Aug 19, 2024
Member
There was a problem hiding this comment.
Looks good afaict.
I will note that there's a comment down on line 1056 saying
// TODO: make this a class `compound expansion content`
.#{$table}__control-row ~ .#{$table}__expandable-row.pf-m-expanded {
that might be good to do in the future to simplify these selectors?
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.218 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6782.
Adjusts padding so it applies padding-block-start to compound expandable rows (and still removes padding for all other types of expandable row).