8000 chore(v6): merge main into v6 by mcoker · Pull Request #6932 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

chore(v6): merge main into v6#6932

Merged
mattnolting merged 10 commits intopatternfly:v6from
mcoker:merge-main-v6-7.29.24
Jul 31, 2024
Merged

chore(v6): merge main into v6#6932
mattnolting merged 10 commits intopatternfly:v6from
mcoker:merge-main-v6-7.29.24

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Jul 29, 2024

@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 29, 2024

@mcoker mcoker requested a review from thatblindgeye July 29, 2024 19:46
@mcoker
Copy link
Contributor Author
mcoker commented Jul 29, 2024

From @thatblindgeye re: tree-view conflicts/changes from #6480

looks like:

  • the Tree view with actions example (~line 589 is where the heading is in the MD file) is missing some tabindex attributes on items with -1 value. Lines 597, 607, 629, and 680 are about where that attribute should be
  • The ### Accessibility section in the MD file should be able to be removed in the PR as well

Otherwise looks like all the changes from main are being pulled into v6 fine

@mcoker mcoker force-pushed the merge-main-v6-7.29.24 branch from e3b4977 to e183d00 Compare July 31, 2024 00:11
@mcoker mcoker requested review from mattnolting and srambach July 31, 2024 01:23
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🍌

Copy link
Collaborator
@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM!

@mattnolting mattnolting merged commit a226678 into patternfly:v6 Jul 31, 2024
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.206 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0