fix(Table): favorite icon styles#6926
Merged
mcoker merged 1 commit intopatternfly:v6from Jul 29, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6926.surge.sh A11y report: https://patternfly-pr-6926-a11y.surge.sh |
mcoker
reviewed
Jul 25, 2024
Comment on lines
789
to
+792
| --#{$button}--m-plain--Color: var(--#{$table}__favorite--m-favorited--c-button--Color); | ||
| --#{$button}--m-plain__icon--Color: var(--#{$table}__favorite--m-favorited--c-button--Color); | ||
|
|
||
| &:is(:hover, :focus) { | ||
| --#{$button}--m-plain--hover--Color: var(--#{$table}__favorite--m-favorited--c-button--Color); | ||
| --#{$button}--hover__icon--Color: var(--#{$table}__favorite--m-favorited--c-button--Color); |
Contributor
There was a problem hiding this comment.
Nice!! You should be able to just replace the existing vars with yours - can you test this and see if it works as expected? The plain icon in this case only has an icon in it, so we should only need to set the __icon vars.
Suggested change
| --#{$button}--m-plain--Color: var(--#{$table}__favorite--m-favorited--c-button--Color); | |
| --#{$button}--m-plain__icon--Color: var(--#{$table}__favorite--m-favorited--c-button--Color); | |
| &:is(:hover, :focus) { | |
| --#{$button}--m-plain--hover--Color: var(--#{$table}__favorite--m-favorited--c-button--Color); | |
| --#{$button}--hover__icon--Color: var(--#{$table}__favorite--m-favorited--c-button--Color); | |
| --#{$button}--m-plain__icon--Color: var(--#{$table}__favorite--m-favorited--c-button--Color); | |
| &:is(:hover, :focus) { | |
| --#{$button}--hover__icon--Color: var(--#{$table}__favorite--m-favorited--c-button--Color); |
Contributor
Author
There was a problem hiding this comment.
Yes, works fine even when replaced
4ee3b6a to
e7f4584
Compare
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.205 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6925