8000 fix(global): use tokens for links/help-text/editable-text by mcoker · Pull Request #6908 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

fix(global): use tokens for links/help-text/editable-text#6908

Merged
srambach merged 1 commit intopatternfly:v6from
mcoker:issue-6869
Jul 19, 2024
Merged

fix(global): use tokens for links/help-text/editable-text#6908
srambach merged 1 commit intopatternfly:v6from
mcoker:issue-6869

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Jul 19, 2024

fixes #6869
fixes #6900

For testing, I verified the styles are showing up as intended, then pasted this into the dev tools console to make sure I was using the right tokens and the hover/focus styles were working as expected, since the hover/focus styles match the default styles, it's hard to validate that part was working.

document.documentElement.style.setProperty("--pf-t--global--text-decoration--editable-text--line--default", "underline green");
document.documentElement.style.setProperty("--pf-t--global--text-decoration--editable-text--style--default", "dotted");
document.documentElement.style.setProperty("--pf-t--global--text-decoration--editable-text--line--hover", "overline green");
document.documentElement.style.setProperty("--pf-t--global--text-decoration--editable-text--style--hover", "wavy");

document.documentElement.style.setProperty("--pf-t--global--text-decoration--help-text--line--default", "underline red");
document.documentElement.style.setProperty("--pf-t--global--text-decoration--help-text--style--default", "dotted");
document.documentElement.style.setProperty("--pf-t--global--text-decoration--help-text--line--hover", "overline red");
document.documentElement.style.setProperty("--pf-t--global--text-decoration--help-text--style--hover", "wavy");

document.documentElement.style.setProperty("--pf-t--global--text-decoration--link--line--default", "underline blue");
document.documentElement.style.setProperty("--pf-t--global--text-decoration--link--style--default", "dotted");
document.documentElement.style.setProperty("--pf-t--global--text-decoration--link--line--hover", "overline blue");
document.documentElement.style.setProperty("--pf-t--global--text-decoration--link--style--hover", "wavy");

@mcoker mcoker requested review from srambach and thatblindgeye July 19, 2024 01:28
@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 19, 2024 •
edited
Loading

Preview: https://patternfly-pr-6908.surge.sh

A11y report: https://patternfly-pr-6908-a11y.surge.sh

@srambach
Copy link
Member
srambach commented Jul 19, 2024

Do we need to apply these to the banner?
--#{$banner}--link--TextDecoration: underline;

srambach
srambach approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be ok to apply the text decoration token to the default banner link style, but given the follow up issue #6907 I'm ok with this as is ✅

@srambach srambach merged commit 5ff4e4a into patternfly:v6 Jul 19, 2024
This was referenced Jul 19, 2024
Closed
Closed
@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 19, 2024

🎉 This PR is included in version 6.0.0-alpha.201 🎉

The release is available on:

Your semantic-release bot 📦🚀

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jul 22, 2024
@mcoker @mattnolting
fix(global): use tokens for links/help-text/editable-text (patternfly…
3b0375c 
…#6908)
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jul 22, 2024
@mcoker @mattnolting
fix(global): use tokens for links/help-text/editable-text (patternfly…
f9f4612 
…#6908)
@mcoker mcoker deleted the issue-6869 branch January 7, 2025 16:52
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srambach srambach srambach approved these changes

@thatblindgeye thatblindgeye Awaiting requested review from thatblindgeye

Assignees

No one assigned

Labels

released on @alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcoker @patternfly-build @srambach
0