8000 chore(backstop): visual regression run by mcoker · Pull Request #6898 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

chore(backstop): visual regression run#6898

Merged
mcoker merged 5 commits intopatternfly:v6from
mcoker:backstop-7.17.24
Jul 17, 2024
Merged

chore(backstop): visual regression run#6898
mcoker merged 5 commits intopatternfly:v6from
mcoker:backstop-7.17.24

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Jul 17, 2024 •
edited
Loading

previous Backstop report

after the updates below - Backstop report

I didn't look at everything in detail but here's what I see in the report:

  • Most failures are from the layout/gutter change from 24px/lg -> 16px/md
  • There was an accordion expanded item font-weight bug I fixed in this PR
  • We still have .pf-m-icon-button-group on a bunch of toolbar groups, looks like those have changed to .pf-m-action-group-plain (toolbar-group--IsActionGroupPlain)

@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 17, 2024 •
edited
Loading

Preview: https://patternfly-pr-6898.surge.sh

A11y report: https://patternfly-pr-6898-a11y.surge.sh

@mcoker mcoker requested review from srambach and thatblindgeye July 17, 2024 14:41
mattnolting
mattnolting approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator
@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge! 🥽

@srambach
Copy link
Member
srambach commented Jul 17, 2024

Just one question - pf-core__components_masthead_html-demos_advanced-integration-with-menu-
options_0_document_0_mobile.png and some others - but not all - the kebab moved in from the edge. I just wasn't sure why some and not others but I realize it's probably going to be affected by fixing the toolbar padding.

srambach
srambach approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@mcoker mcoker merged commit 5c68471 into patternfly:v6 Jul 17, 2024
@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 17, 2024

🎉 This PR is included in version 6.0.0-alpha.193 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker deleted the backstop-7.17.24 branch January 7, 2025 16:52
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattnolting mattnolting mattnolting approved these changes

@srambach srambach srambach approved these changes

@thatblindgeye thatblindgeye Awaiting requested review from thatblindgeye

Assignees

No one assigned

Labels

released on @alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcoker @patternfly-build @srambach @mattnolting
0