8000 fix(toolbar): changed toolbar `inline-padding` default to zero, updated toolbar demo examples by mattnolting · Pull Request #6893 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

fix(toolbar): changed toolbar inline-padding default to zero, updated toolbar demo examples#6893

Merged
mcoker merged 3 commits intopatternfly:v6from
mattnolting:fix-toolbar-beta
Jul 18, 2024
Merged

fix(toolbar): changed toolbar inline-padding default to zero, updated toolbar demo examples#6893
mcoker merged 3 commits intopatternfly:v6from
mattnolting:fix-toolbar-beta

Conversation

@mattnolting
Copy link
Collaborator
@mattnolting mattnolting commented Jul 16, 2024 •
edited
Loading

closes #6889

  • updated toolbar-group--modifier="pf-m-icon-button-group" to toolbar-group--IsActionGroupPlain=true
  • updated toolbar-group--modifier="pf-m-filter-group" to toolbar--IsFilterGroup=true
  • updated toolbar-group--modifier="pf-m-icon-button-group" to toolbar-group--IsActionGroupPlain=true
  • removed page-main-section--modifier='pf-m-no-padding from demos/examples
  • updated demo padding
  • set toolbar padding inline to zero

@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 16, 2024 •
edited
Loading

Preview: https://patternfly-pr-6893.surge.sh

A11y report: https://patternfly-pr-6893-a11y.surge.sh

@mattnolting mattnolting force-pushed the fix-toolbar-beta branch 2 times, most recently from 0571a72 to 304b592 Compare July 17, 2024 15:35
@mcoker
Copy link
Contributor
mcoker commented Jul 17, 2024

Backstop report - https://drive.google.com/file/d/1bBRkLeCs9K7PyNbOc0M5xSWy6YWlJRwP/view?usp=sharing

mcoker
mcoker approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcoker
Copy link
Contributor
mcoker commented Jul 17, 2024

@mattnolting there are 2 conflicts. I resolved them locally (to run the screenshots) by checking in your changes for src/patternfly/demos/Masthead/masthead-template-content-icon-group.hbs though the lines look identical so I don't think it matters, and checking in the existing v6 code for src/patternfly/demos/Toolbar/toolbar-template.hbs because v6 has {{#> toolbar-group toolbar-group--IsActionGroupPlain=true toolbar-group--modifier="pf-m-align-end"}} and yours is missing toolbar-group--IsActionGroupPlain=true, even though the toolbar items in that group are plain buttons.

@mcoker mcoker mentioned this pull request Jul 18, 2024
Open
srambach
srambach approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good!

@mcoker mcoker merged commit 440c492 into patternfly:v6 Jul 18, 2024
@mcoker mcoker mentioned this pull request Jul 18, 2024
Closed
@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 18, 2024

🎉 This PR is included in version 6.0.0-alpha.197 🎉

The release is available on:

Your semantic-release bot 📦🚀

@patternfly-build patternfly-build mentioned thi 8000 s pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srambach srambach srambach approved these changes

@mcoker mcoker mcoker approved these changes

@thatblindgeye thatblindgeye Awaiting requested review from thatblindgeye

@kaylachumley kaylachumley Awaiting requested review from kaylachumley

@lboehling lboehling Awaiting requested review from lboehling

Assignees

No one assigned

Labels

released on @alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mattnolting @patternfly-build @mcoker @srambach
0