E527 chore(screenshots): update fullpage screenshots by mcoker · Pull Request #6874 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

chore(screenshots): update fullpage screenshots#6874

Merged
mcoker merged 1 commit intopatternfly:v6from
mcoker:update-fullpage-screenshots-7.10.24
Jul 15, 2024
Merged

chore(screenshots): update fullpage screenshots#6874
mcoker merged 1 commit intopatternfly:v6from
mcoker:update-fullpage-screenshots-7.10.24

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Jul 11, 2024

No description provided.

@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 11, 2024

@evwilkin
Copy link
Member

@mcoker there are a lot of changes here, is there anything specifically to review or just a broad updating of screenshots?

@mcoker
Copy link
Contributor Author
mcoker commented Jul 15, 2024

@evwilkin with the full page screenshots, it's usually just a quick check to make sure nothing looks way off. This is mostly to give a more accurate representation of what the full page example/demo actually looks like. Visual regression tests should uncover the big bugs.

Copy link
Member
@evwilkin evwilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoker mcoker merged commit 2b4fef4 into patternfly:v6 Jul 15, 2024
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.192 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker deleted the update-fullpage-screenshots-7.10.24 branch January 7, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0