8000 fix(table-tree-view): reset table tree view th header cell min/max-width, width , and display by mattnolting · Pull Request #6868 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

fix(table-tree-view): reset table tree view th header cell min/max-width, width , and display#6868

Merged
mcoker merged 3 commits intopatternfly:v6from
mattnolting:fix-table-tree-view-6865
Jul 18, 2024
Merged

fix(table-tree-view): reset table tree view th header cell min/max-width, width , and display#6868
mcoker merged 3 commits intopatternfly:v6from
mattnolting:fix-table-tree-view-6865

Conversation

@mattnolting
Copy link
Collaborator

fixes #6865

@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 9, 2024

@mcoker
Copy link
Contributor
mcoker commented Jul 10, 2024

adding @lboehling and @andrew-ronaldson. @mattnolting please fill in any missing details, but I believe you made a change to the table in a previous PR to keep the table column header visible for the first column in a tree table on mobile. This PR just fixes a visual bug with that, but I don't think design had reviewed the initial change, so I want to make sure this is how design wants to present the table.

I think the reasoning for leaving the column header visible is because, in a tree table, the first column includes the toggle (a checkbox if it's selectable) and the node/toggle/column text, so we don't move the column header down into the display for that cell like we do other cells in the row.

Some screenshots:

Desktop view
Screenshot 2024-07-09 at 8 41 48 PM

Mobile view
Screenshot 2024-07-09 at 8 40 58 PM

Mobile view in a page
Screenshot 2024-07-09 at 8 41 58 PM

And for comparison, here is v5 since it didn't include the header

Desktop view
Screenshot 2024-07-09 at 8 51 51 PM

Mobile view
Screenshot 2024-07-09 at 8 51 55 PM

@mattnolting mattnolting force-pushed the fix-table-tree-view-6865 branch from bf3e532 to 0187fcc Compare July 18, 2024 19:07
@mcoker mcoker force-pushed the fix-table-tree-view-6865 branch from 0187fcc to 57eef9a Compare July 18, 2024 20:11
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM!

@mcoker mcoker merged commit 1713832 into patternfly:v6 Jul 18, 2024
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.200 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0