E52F fix(layouts): updating gutters tokens by andrew-ronaldson · Pull Request #6863 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

fix(layouts): updating gutters tokens#6863

Merged
mcoker merged 1 commit intopatternfly:v6from
andrew-ronaldson:layout-spacers
Jul 11, 2024
Merged

fix(layouts): updating gutters tokens#6863
mcoker merged 1 commit intopatternfly:v6from
andrew-ronaldson:layout-spacers

Conversation

@andrew-ronaldson
Copy link
Collaborator
@andrew-ronaldson andrew-ronaldson commented Jul 9, 2024

Closes #6771

One question I have is the Flex layout update. Not sure if this is intended @lboehling ?

--#{$flex}--spacer--column--base: var(--pf-t--global--spacer--gutter--default); // default spacer/gap for columns

That trickles down as the base for other spacers. It was using spacer--lg before the update.

@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 9, 2024 •
edited
Loading

Preview: https://patternfly-pr-6863.surge.sh

A11y report: https://patternfly-pr-6863-a11y.surge.sh

@mcoker
Copy link
Contributor
mcoker commented Jul 10, 2024

The flex layout has always kinda been it's own thing, though I don't know why it wouldn't match the other layouts. I give this update 👍👍 and a 🐸 for good measure.

Just some more info - the one thing that's different about the flex layout is it has the column gap (16px per this PR) and row gap (8px via spacer--sm) by default, and they're completely, independently adjustable. The other layouts do not have a gap/gutter unless you add the modifier .pf-m-gutter, and you just get the fixed gutter.

mcoker
mcoker approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

(rawr)
      🦖

@mattnolting mattnolting self-requested a review July 11, 2024 15:45
mattnolting
mattnolting approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator
@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done LPTM 🐸

lboehling
lboehling approved these changes Jul 11, 2024
View reviewed changes
Copy link
@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!! yes agree, i think flex should match the other layouts

@mcoker mcoker merged commit b9519a8 into patternfly:v6 Jul 11, 2024
@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 11, 2024

🎉 This PR is included in version 6.0.0-alpha.188 🎉

The release is available on:

Your semantic-release bot 📦🚀

@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattnolting mattnolting mattnolting approved these changes

@mcoker mcoker mcoker approved these changes

@lboehling lboehling lboehling approved these changes

Assignees

No one assigned

Labels

released on @alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andrew-ronaldson @patternfly-build @mcoker @mattnolting @lboehling
0