feat(tokens): use rems instead of px for most sizes#6846
Merged
mcoker merged 2 commits intopatternfly:v6from Jul 3, 2024
Merged
feat(tokens): use rems instead of px for most sizes#6846mcoker merged 2 commits intopatternfly:v6from
mcoker merged 2 commits intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6846.surge.sh A11y report: https://patternfly-pr-6846-a11y.surge.sh |
mcoker
reviewed
Jul 3, 2024
Comment on lines
+293
to
+304
| --pf-t--global--text-decoration--editable-text--line--default: var(--pf-t--global--text-decoration--line--200); | ||
| --pf-t--global--text-decoration--editable-text--line--hover: var(--pf-t--global--text-decoration--line--200); | ||
| --pf-t--global--text-decoration--editable-text--style--default: var(--pf-t--global--text-decoration--style--200); | ||
| --pf-t--global--text-decoration--editable-text--style--hover: var(--pf-t--global--text-decoration--style--200); | ||
| --pf-t--global--text-decoration--help-text--line--default: var(--pf-t--global--text-decoration--line--200); | ||
| --pf-t--global--text-decoration--help-text--line--hover: var(--pf-t--global--text-decoration--line--200); | ||
| --pf-t--global--text-decoration--help-text--style--default: var(--pf-t--global--text-decoration--style--200); | ||
| --pf-t--global--text-decoration--help-text--style--hover: var(--pf-t--global--text-decoration--style--200); | ||
| --pf-t--global--text-decoration--link--line--default: var(--pf-t--global--text-decoration--style--200); | ||
| --pf-t--global--text-decoration--link--line--hover: var(--pf-t--global--text-decoration--style--200); | ||
| --pf-t--global--text-decoration--link--style--default: var(--pf-t--global--text-decoration--style--100); | ||
| --pf-t--global--text-decoration--link--style--hover: var(--pf-t--global--text-decoration--style--100); |
mcoker
approved these changes
Jul 3, 2024
Contributor
There was a problem hiding this comment.
It's... just so beautiful 🥹
Comment on lines
+457
to
+458
| --pf-t--global--spacer--action--vertical--default: var(--pf-t--global--spacer--sm); | ||
| --pf-t--global--spacer--action--vertical--plain: var(--pf-t--global--spacer--sm); |
Contributor
There was a problem hiding this comment.
@lboehling can you confirm these are intentional? Last I remember we were using --pf-t--global--spacer--control--vertical[...] for the top/bottom padding of actions/controls so that we used a single spacer.
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.181 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6830 to change px values for sizes, spacers, and breakpoints to rems. Does not change box-shadow and border sizing.
Also includes updates to font definitions and a couple of semantic spacers.
(0 visual differences when run with just the rem change)