8000 feat(wizard): add support for success step by mcoker · Pull Request #6844 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

feat(wizard): add support for success step#6844

Merged
mcoker merged 3 commits intopatternfly:v6from
mcoker:wizard-success-status
Jul 2, 2024
Merged

feat(wizard): add support for success step#6844
mcoker merged 3 commits intopatternfly:v6from
mcoker:wizard-success-status

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Jul 2, 2024

@mcoker mcoker requested a review from nicolethoen July 2, 2024 17:16
@patternfly-build
Copy link
Collaborator
patternfly-build commented Jul 2, 2024

@mcoker mcoker requested a review from srambach July 2, 2024 17:57
Copy link
Collaborator
@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM 👍

{{/wizard-inner-wrap}}
{{> wizard-footer}}
{{/wizard-outer-wrap}}
{{/wizard}} No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{/wizard}}
{{/wizard}}

{{{wizard-nav-link-status-icon--attribute}}}
{{/if}}>
{{> @partial-block}}
<i class="fas fa-{{ternary wizard-nav-item--IsSuccess 'check-circle' 'exclamation-circle'}}" aria-hidden="true"></i>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

8000
{{/wizard-nav-link-status-icon}}
{{/if}}
{{#ifAny wizard-nav-item--IsSuccess wizard-nav-item--IsDanger}}
{{> wizard-nav-link-status-icon}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor
@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐎

Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like wizard-info was renamed? Otherwise 🧙

@mcoker mcoker requested a review from srambach July 2, 2024 19:40
@mcoker mcoker merged commit 44d7b47 into patternfly:v6 Jul 2, 2024
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.180 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0