E52C fix(wizard): added border to wizard header by andrew-ronaldson · Pull Request #6820 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

fix(wizard): added border to wizard header#6820

Merged
mcoker merged 2 commits intopatternfly:v6from
andrew-ronaldson:youre-a-wizard-andy
Jun 25, 2024
Merged

fix(wizard): added border to wizard header#6820
mcoker merged 2 commits intopatternfly:v6from
andrew-ronaldson:youre-a-wizard-andy

Conversation

@andrew-ronaldson
Copy link
Collaborator

Closes #6803

@patternfly-build
Copy link
Collaborator
patternfly-build commented Jun 23, 2024

Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tho one question - should we use border--width--regular or border--width--divider? And do we need to update any of these borders to match?

https://github.com/patternfly/patternfly/blob/a09e0be720e6d233d23bfdfa484a5987cff7dfa3/src/patternfly/components/Wizard/wizard.scss#L15C3-L15C90

--#{$wizard}__toggle--BorderBlockEndWidth: var(--pf-t--global--border--width--regular);

--#{$wizard}__nav--lg--BorderInlineEndWidth: var(--pf-t--global--border--width--regular);

--#{$wizard}__footer--BorderBlockStartWidth: var(--pf-t--global--border--width--divider--default);

edit: @lboehling confirmed we should be using border--width--divider for these borders, so we'll need to update them before merging.

Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

@mcoker mcoker merged commit 469edd3 into patternfly:v6 Jun 25, 2024
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.173 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0