8000 chore(data-list): remove card from demos by andrew-ronaldson · Pull Request #6811 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

chore(data-list): remove card from demos#6811

Merged
mcoker merged 3 commits intopatternfly:v6from
andrew-ronaldson:data-list
Jun 24, 2024
Merged

chore(data-list): remove card from demos#6811
mcoker merged 3 commits intopatternfly:v6from
andrew-ronaldson:data-list

Conversation

@andrew-ronaldson
Copy link
Collaborator
@andrew-ronaldson andrew-ronaldson commented Jun 21, 2024

Closes #6795

@patternfly-build
Copy link
Collaborator
patternfly-build commented Jun 21, 2024 •
edited
Loading

Preview: https://patternfly-pr-6811.surge.sh

A11y report: https://patternfly-pr-6811-a11y.surge.sh

mcoker
mcoker reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a quick glance - I noticed these table demos are in a card, too - should we update them?

https://patternfly-pr-6811.surge.sh/components/table/html-demos/sortable/
https://patternfly-pr-6811.surge.sh/components/table/html-demos/expandable/
https://patternfly-pr-6811.surge.sh/components/table/html-demos/compact/
https://patternfly-pr-6811.surge.sh/components/table/html-demos/compound-expansion/
https://patternfly-pr-6811.surge.sh/components/table/html-demos/loading-state-demo/
https://patternfly-pr-6811.surge.sh/components/table/html-demos/empty-state/
https://patternfly-pr-6811.surge.sh/components/table/html-demos/static-bottom-pagination/
https://patternfly-pr-6811.surge.sh/components/table/html-demos/column-management-modal/
https://patternfly-pr-6811.surge.sh/components/table/html-demos/sticky-header/

@andrew-ronaldson
chore(table): update table examples
b6d76ba 
Removed Card styling from tables demos
mcoker
mcoker approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L👏 G👏 T👏 M👏

mattnolting
mattnolting approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator
@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM! Thanks Andrew!

@mcoker @mattnolting
Update src/patternfly/demos/Table/examples/Table.md
e301388 
Co-authored-by: Matt Nolting <matthew.nolting@gmail.com>
@mcoker mcoker merged commit cfecbfd into patternfly:v6 Jun 24, 2024
@mcoker mcoker mentioned this pull request Jun 24, 2024
Closed
@patternfly-build
Copy link
Collaborator
patternfly-build commented Jun 24, 2024

🎉 This PR is included in version 6.0.0-alpha.169 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker mentioned this pull request Jun 25, 2024
Merged
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattnolting mattnolting mattnolting approved these changes

@mcoker mcoker mcoker approved these changes

@srambach srambach Awaiting requested review from srambach

@kaylachumley kaylachumley Awaiting requested review from kaylachumley

Assignees

No one assigned

Labels

released on @alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrew-ronaldson @patternfly-build @mattnolting @mcoker
0