feat(alert-group): animate addition and removal of alerts#6804
Merged
mcoker merged 3 commits intopatternfly:v6from Jun 20, 2024
Merged
feat(alert-group): animate addition and removal of alerts#6804mcoker merged 3 commits intopatternfly:v6from
mcoker merged 3 commits intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6804.surge.sh A11y report: https://patternfly-pr-6804-a11y.surge.sh |
mcoker
approved these changes
Jun 20, 2024
Contributor
There was a problem hiding this comment.
lgtm! We can clean up the vars in a follow-up.
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.167 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add animation on the alert group item when adding/removing an item.
For expediency, for now there are no additional component variables - motion tokens are used directly in the transitions.
One other TODO remains: a toast alert that times out should leave in the same way, but have a slower duration than an alert that is dismissed.
To test, go to the toast alert full page example. Add
.pf-m-offstage-topto simulate the starting condition. Remove it to see the alert appear (slide in from the top). To simulate removal, add the.pf-m-offstage-rightclass and see it slide to the right.To test reduced motion, turn on "Reduce motion" in the Display settings (MacOS). When this option is on, only opacity should transition and nothing should slide.
Fixes #6592