8000 fix(clipboard-copy): adjust inline icons by mcoker · Pull Request #6788 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

fix(clipboard-copy): adjust inline icons#6788

Merged
mcoker merged 1 commit intopatternfly:v6from
mcoker:issue-6762
Jun 18, 2024
Merged

fix(clipboard-copy): adjust inline icons#6788
mcoker merged 1 commit intopatternfly:v6from
mcoker:issue-6762

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Jun 13, 2024

fixes #6762

@andrew-ronaldson is there a formula for when we use the subtle icon color by default and regular color on hover? I know we've added that in a few places, but it currently exists as overrides in components where that style exists. I'm wondering if this should be a variation or something instead. Should the "no padding" icon button have this style by default?

FWIW here are all of the places in the CSS we're using that token. I can provide more info if that's helpful

ClipboardCopy/clipboard-copy.scss:  --#{$clipboard-copy}__actions-item--button--Color: var(--pf-t--global--icon--color--subtle);
DataList/data-list.scss:  --#{$data-list}__item-draggable-button-icon--Color: var(--pf-t--global--icon--color--subtle);
DescriptionList/description-list.scss:  --#{$description-list}__term-icon--Color: var(--pf-t--global--icon--color--subtle);
EmptyState/empty-state.scss:  --#{$empty-state}__icon--Color: var(--pf-t--global--icon--color--subtle);
HelperText/helper-text.scss:  --#{$helper-text}__item-icon--m-indeterminate--Color: var(--pf-t--global--icon--color--subtle);
HelperText/helper-text.scss:  --#{$helper-text}--m-dynamic--m-indeterminate__item-icon--Color: var(--pf-t--global--icon--color--subtle);
Menu/menu.scss:  --#{$menu}__item-action--Color: var(--pf-t--global--icon--color--subtle);
Menu/menu.scss:  --#{$menu}__item-select-icon--Color: var(--pf-t--global--icon--color--subtle);
Nav/nav.scss:  --#{$nav}__link-icon--Color: var(--pf-t--global--icon--color--subtle);
Slider/slider.scss:  --#{$slider}__step-tick--BackgroundColor: var(--pf-t--global--icon--color--subtle);
Switch/switch.scss:  --#{$switch}__input--not-checked__toggle--before--BackgroundColor: var(--pf-t--global--icon--color--subtle);
Table/table.scss:  --#{$table}__sort-indicator--Color: var(--pf-t--global--icon--color--subtle);
TreeView/tree-view.scss:  --#{$tree-view}__node-toggle--Color--base: var(--pf-t--global--icon--color--subtle);
TreeView/tree-view.scss:  --#{$tree-view}__node-icon--Color: var(--pf-t--global--icon--color--subtle);

@patternfly-build
Copy link
Collaborator
patternfly-build commented Jun 13, 2024 •
edited
Loading

Preview: https://patternfly-pr-6788.surge.sh

A11y report: https://patternfly-pr-6788-a11y.surge.sh

@andrew-ronaldson andrew-ronaldson self-requested a review June 17, 2024 15:25
andrew-ronaldson
andrew-ronaldson approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator
@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy clipboard looks totally righeous!
To your larger question I think the no-padding buttons should have the subtle > Regular icon color on hover

@mcoker mcoker requested a review from srambach June 17, 2024 15:55
srambach
srambach approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 📋

@mcoker mcoker merged commit 9fd8280 into patternfly:v6 Jun 18, 2024
@patternfly-build
Copy link
Collaborator
patternfly-build commented Jun 18, 2024

🎉 This PR is included in version 6.0.0-alpha.163 🎉

The release is available on:

Your semantic-release bot 📦🚀

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jun 21, 2024
@mcoker
fix(clipboard-copy): adjust inline icons (patternfly#6788)
d3c81e7
@mcoker mcoker deleted the issue-6762 branch January 7, 2025 16:55
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srambach srambach srambach approved these changes

@andrew-ronaldson andrew-ronaldson andrew-ronaldson approved these changes

Assignees

No one assigned

Labels

released on @alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mcoker @patternfly-build @srambach @andrew-ronaldson
0