8000 fix(tokens): update cyan/gold to teal/yellow by mcoker · Pull Request #6786 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

fix(tokens): update cyan/gold to teal/yellow#6786

Merged
mcoker merged 3 commits intopatternfly:v6from
mcoker:issue-6742
Jun 13, 2024
Merged

fix(tokens): update cyan/gold to teal/yellow#6786
mcoker merged 3 commits intopatternfly:v6from
mcoker:issue-6742

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Jun 13, 2024

fixes #6742

related design tokens PR with this change https://github.com/patternfly/design-tokens/pull/63/files

The 3 commits in this PR:

  • f743b2a
    • copy/pasta of built CSS from design tokens PR reference above
    • Manually fixed these stylelint errors by wrapping the font family names in quotes and changed the heading line-height to 1.3. 
      src/patternfly/base/tokens/tokens-default.scss
67:43  ✖  Expected "1.2999999523162842" to be "1.3000"  number-max-precision
72:38  ✖  Unexpected named color "Red"                  color-named
73:38  ✖  Unexpected named color "Red"                  color-named
74:38  ✖  Unexpected named color "Red"                  color-named
  • d0fc178
    • Moved tokens.local to load last so it can override tokens from figma
  • 038a8c2
    • Renames gold to yellow and cyan to teal everywhere via 4 case-sensitive search/replace commands in vscode (Gold -> Yellow, gold -> yellow, Cyan -> Teal, cyan -> teal)

@patternfly-build
Copy link
Collaborator
patternfly-build commented Jun 13, 2024 •
edited
Loading

Preview: https://patternfly-pr-6786.surge.sh

A11y report: https://patternfly-pr-6786-a11y.surge.sh

srambach
srambach approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM 💛🩵

lboehling
lboehling approved these changes Jun 13, 2024
View reviewed changes
Copy link
@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@mcoker mcoker merged commit 02442aa into patternfly:v6 Jun 13, 2024
This was referenced Jun 13, 2024
Closed
Closed
@patternfly-build
Copy link
Collaborator
patternfly-build commented Jun 13, 2024

🎉 This PR is included in version 6.0.0-alpha.160 🎉

The release is available on:

Your semantic-release bot 📦🚀

mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jun 21, 2024
@mcoker
fix(tokens): update cyan/gold to teal/yellow (patternfly#6786)
74490f4
@mcoker mcoker deleted the issue-6742 branch January 7, 2025 16:55
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srambach srambach srambach approved these changes

@lboehling lboehling lboehling approved these changes

@thatblindgeye thatblindgeye thatblindgeye approved these changes

Assignees

No one assigned

Labels

released on @alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3B1B 5 participants

@mcoker @patternfly-build @srambach @lboehling @thatblindgeye
0