fix(global): base stylesheets cleanup#6748
Merged
mcoker merged 1 commit intopatternfly:v6from Jun 6, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6748.surge.sh A11y report: https://patternfly-pr-6748-a11y.surge.sh |
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.151 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 6, 2024
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6747
fixes #6679
@srambach @mattnolting changes discussed from today's working session, except I also moved reset.scss to come before normalize.scss. Seems like a change we would want to make - wdyt? I'll also run visual regression tests to make sure nothing unexpected changed from that.