fix(action-list): updated icon spacer to xs#6746
Conversation
|
Preview: https://patternfly-pr-6746.surge.sh A11y report: https://patternfly-pr-6746-a11y.surge.sh |
There was a problem hiding this comment.
We have some semantic spacers being handled in another issue, so I wasn't sure if they were ready to be used yet, but confirmed with @lboehling that they're good to go 🚀
Up to you if you want to go ahead and update the rest of the spacers in this component. If so I'm thinking we can update the following - @lboehling can you confirm this is correct?
- Default row gap (for when actions wrap) -
--#{$action-list}--RowGap - Default column gap (space between groups and/or standalone items not in a group) -
--#{$action-list}--ColumnGap - Default group column gap (space between actions in a group)
--#{$action-list}__group--ColumnGap-
|
|
||
| // * Action list icons | ||
| --#{$action-list}--m-icons--ColumnGap: var(--pf-t--global--spacer--sm); | ||
| --#{$action-list}--m-icons--ColumnGap: var(--pf-t--global--spacer--xs); |
There was a problem hiding this comment.
Confirmed with @lboehling we can go ahead and use the semantic spacer here!
| --#{$action-list}--m-icons--ColumnGap: var(--pf-t--global--spacer--xs); | |
| --#{$action-list}--m-icons--ColumnGap: var(--pf-t--global--spacer--gap--action-to-action--plain); |
Just for reference, here it is in the core tokens file
|
those tokens look right to me @mcoker @mattnolting! |
353ffa6 to
4a3f1dd
Compare
|
🎉 This PR is included in version 6.0.0-alpha.154 🎉 The release is available on: Your semantic-release bot 📦🚀 |
closes #6745