feat(menu): add transitions for menu and items in menu#6740
Merged
mcoker merged 1 commit intopatternfly:v6from Jun 11, 2024
Merged
feat(menu): add transitions for menu and items in menu#6740mcoker merged 1 commit intopatternfly:v6from
mcoker merged 1 commit intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6740.surge.sh A11y report: https://patternfly-pr-6740-a11y.surge.sh |
andrew-ronaldson
approved these changes
Jun 11, 2024
Collaborator
There was a problem hiding this comment.
You've done it again! Remarkable
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.157 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds transitions for the menu items, and for the menu itself. Note that for the menu as a whole, popper is controlling it being shown and hidden, so this PR uses !important to override the settings of Popper. Also note that the current implementation of Popper doesn't allow for the menu to slide, but simply transitions opacity.
A follow-on issue should address the motion currently happening in the drill-down menu.
Implements part of #6590