fix(charts): renamed cyan to teal, gold to yellow#6735
Merged
mcoker merged 1 commit intopatternfly:v6from Jun 4, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6735.surge.sh A11y report: https://patternfly-pr-6735-a11y.surge.sh |
thatblindgeye
approved these changes
Jun 4, 2024
Contributor
There was a problem hiding this comment.
This looks good. Is there a plan to update other tokens still using the old color names? E.g. in the tokens default file we still have --pf-t--global--color--nonstatus--gold--300: var(--pf-t--color--yellow--40);
Contributor
Author
|
@thatblindgeye nice callout, opened #6742 for that change (depends on patternfly/design-tokens#62) |
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.150 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6693