fix(card): move borders to pseudoelement#6705
Conversation
|
Preview: https://patternfly-pr-6705.surge.sh A11y report: https://patternfly-pr-6705-a11y.surge.sh |
|
@srambach I ended up removing 2 unneeded |
|
I think those reverts were there because on clickable and selectable cards, there should not be a border when the checkbox is checked, only when it's pf-m- 8000 current. You can see the difference on https://patternfly-pr-6705.surge.sh/components/card/#clickable-and-selectable vs. https://pf6.patternfly.org/components/card#clickable-and-selectable (click the checkbox on the first card) |
|
@srambach you're right, I was testing this incorrectly locally so thanks for pointing this out. I don't see the background color rule having any effect, but I added back both removed rules out as maybe the background is affected outside of the use case in the example? The border revert rules are definitely needed to prevent the border color & size changes on focus-visible/selected. 👍 |
There was a problem hiding this comment.
Actually, one sec - I'm seeing a flash when the checkbox is checked now https://patternfly-pr-6705.surge.sh/components/card/#selectable
Nope nevermind - artifact of the inspector apparently.
|
🎉 This PR is included in version 6.0.0-alpha.155 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #6234
This PR:
::beforepseudoelementrevertrules