fix(modal): split padding between header & body#6699
Merged
mcoker merged 1 commit intopatternfly:v6from May 31, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6699.surge.sh A11y report: https://patternfly-pr-6699-a11y.surge.sh |
Contributor
|
v5 vs v6 with a background on the modal body for comparison - cc @lboehling @kaylachumley v5 not scrolled 
v5 scrolled 
v6 not scrolled 
v6 scrolled 
|
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.147 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6304
This PR splits the 16px top padding from the modal body into 8px top padding and moves the remaining 8px to bottom padding on the modal header.