fix(docs): update backstop selector & reference images#6692
Merged
mcoker merged 1 commit intopatternfly:v6from May 23, 2024
Merged
fix(docs): update backstop selector & reference images#6692mcoker merged 1 commit intopatternfly:v6from
mcoker merged 1 commit intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6692.surge.sh A11y report: https://patternfly-pr-6692-a11y.surge.sh |
mcoker
approved these changes
May 23, 2024
Contributor
There was a problem hiding this comment.
Awesome!! Thanks for handling this on org and core!! And now you're a screenshot ninja🥷
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.140 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mattnolting
pushed a commit
to mattnolting/patternfly
that referenced
this pull request
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6602
This PR updates the
readySelectorfor backstop visual regression testing to the.page-loadedclass which is ideally added after the page and images for each example have fully loaded.This PR also updates the reference images for backstop.