8000 fix(charts): update dark label color token by mcoker · Pull Request #6686 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

fix(charts): update dark label color token#6686

Merged
mcoker merged 3 commits intopatternfly:v6from
mcoker:issue-6685
May 23, 2024
Merged

fix(charts): update dark label color token#6686
mcoker merged 3 commits intopatternfly:v6from
mcoker:issue-6685

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented May 22, 2024

fixes #6685

@lboehling just want to make sure the changes to the hex values in the palette token file are intentional? Looks to just change a handful of shorter hex values to the long/full value (eg #06c to #0066cc) nevermind, core has a linter rule that complains about long hex values that can be shorter. Let the linter fix it for now, we may consider aligning on that format in the future

@mcoker mcoker requested review from lboehling and srambach May 22, 2024 20:38
@patternfly-build
Copy link
Collaborator
patternfly-build commented May 22, 2024

Copy link
Member
@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@mcoker mcoker merged commit 3ab5227 into patternfly:v6 May 23, 2024
@patternfly-build
Copy link
Collaborator

🎉 This PR is included in version 6.0.0-alpha.138 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0