8000 chore(Wizard): resolved scroll issue and used ActionList for wizard buttons by thatblindgeye · Pull Request #6611 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

chore(Wizard): resolved scroll issue and used ActionList for wizard buttons#6611

Merged
mcoker merged 2 commits intopatternfly:v6from
thatblindgeye:iss6314_wizardFollowup
May 16, 2024
Merged

chore(Wizard): resolved scroll issue and used ActionList for wizard buttons#6611
mcoker merged 2 commits intopatternfly:v6from
thatblindgeye:iss6314_wizardFollowup

Conversation

@thatblindgeye
Copy link
Contributor
@thatblindgeye thatblindgeye commented May 2, 2024

Closes #6314

@thatblindgeye thatblindgeye requested a review from mcoker May 2, 2024 18:17
@patternfly-build
Copy link
Collaborator
patternfly-build commented May 2, 2024 •
edited
Loading

Preview: https://patternfly-pr-6611.surge.sh

A11y report: https://patternfly-pr-6611-a11y.surge.sh

@thatblindgeye thatblindgeye linked an issue May 2, 2024 that may be closed by this pull request
Wizard follow ups #6314
Closed
mcoker
mcoker requested changes May 15, 2024
View reviewed changes
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think we can now update the footer just to be a regular box since the action list provides the button layout we need. We can take off all the flex stuff and child styling. Another thing to look for is the footer's bottom padding currently accounts for the bottom margin we're adding to children (buttons) in the footer, so that padding will likely need to be updated, too.

patternfly/src/patternfly/components/Wizard/wizard.scss

Lines 513 to 533 in c3f6c81

.#{$wizard}__footer {
position: relative;
z-index: var(--#{$wizard}__footer--ZIndex);
display: flex;
flex-shrink: 0;
flex-wrap: wrap;
padding-block-start: var(--#{$wizard}__footer--PaddingBlockStart);
padding-block-end: var(--#{$wizard}__footer--PaddingBlockEnd);
padding-inline-start: var(--#{$wizard}__footer--PaddingInlineStart);
padding-inline-end: var(--#{$wizard}__footer--PaddingInlineEnd);
background-color: var(--#{$wizard}__footer--BackgroundColor);
border-block-start: var(--#{$wizard}__footer--BorderWidth) solid var(--#{$wizard}__footer--BorderColor);
> * {
margin-block-end: var(--#{$wizard}__footer--child--MarginBlockEnd);
&:not(:last-child) {
margin-inline-end: var(--#{$wizard}__footer--child--MarginInlineEnd);
}
}
}

@thatblindgeye thatblindgeye force-pushed the iss6314_wizardFollowup branch from 5641104 to 5696459 Compare May 16, 2024 12:22
@thatblindgeye
Copy link
Contributor Author
thatblindgeye commented May 16, 2024

@mcoker Updated, but just to note In React, a consumer would still be able to create a custom footer that doesn't use ActionList (see custom footer example). In those scenarios, I assume we'd just recommend either using Action List or utilizing our flex layouts?

mcoker
mcoker approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor
@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳🍕

@mcoker mcoker merged commit 3070ad9 into patternfly:v6 May 16, 2024
@thatblindgeye thatblindgeye mentioned this pull request May 16, 2024
Closed
@mcoker mcoker mentioned this pull request May 29, 2024
Closed
mattnolting pushed a commit to mattnolting/patternfly that referenced this pull request Jun 21, 2024
@thatblindgeye
fix(Wizard): resolved scroll issue and used ActionList for wizard but…
a16d8c3 
…tons (patternfly#6611)
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcoker mcoker mcoker approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wizard follow ups

3 participants

@thatblindgeye @patternfly-build @mcoker
0