8000 chore(build): update packages by mcoker · Pull Request #6523 · patternfly/patternfly · GitHub
[go: up one dir, main page]
Skip to content

chore(build): update packages#6523

Merged
wise-king-sullyman merged 3 commits intopatternfly:v6from
mcoker:issue-6522
Apr 5, 2024
Merged

chore(build): update packages#6523
wise-king-sullyman merged 3 commits intopatternfly:v6from
mcoker:issue-6522

Conversation

@mcoker
Copy link
Contributor
@mcoker mcoker commented Apr 5, 2024 •
edited
Loading

fixes #6519

The deets:

  • Updates all dependencies to latest using ncu -u
  • Found a problem with the gulp major version bump from 4.x -> 5.x, so reverted the gulp and gulp-cli versions for this PR
  • Removes the gulp lintCSS scripts - that checks for 2 things, which we can do better than that script is doing
    • Checks for valid use of CSS functions compared to a static list of valid function names in the gulpfile. We just don't need that AFAIK, stylelint can do that for us, and furthermore functions will not work if invalid
    • Checks for CSS comments in the compiled CSS. This is good, but we actively maintain our stylelint rules, and stylelint-css has a rule for that, comment-no-loud that I added to our stylelint config

@patternfly-build
Copy link
Collaborator
patternfly-build commented Apr 5, 2024 •
edited
Loading

Preview: https://patternfly-pr-6523.surge.sh

A11y report: https://patternfly-pr-6523-a11y.surge.sh

mattnolting
mattnolting approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator
@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! 🚢 👍

@mcoker mcoker linked an issue Apr 5, 2024 that may be closed by this pull request
Update dependencies for v6 #6519
Closed
@mcoker mcoker mentioned this pull request Apr 5, 2024
Closed
@mcoker mcoker requested review from wise-king-sullyman and removed request for nicolethoen April 5, 2024 18:15
@mcoker mcoker mentioned this pull request Apr 5, 2024
Closed
wise-king-sullyman
wise-king-sullyman approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator
@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@wise-king-sullyman wise-king-sullyman merged commit fe7b55e into patternfly:v6 Apr 5, 2024
@patternfly-build
Copy link
Collaborator
patternfly-build commented Apr 9, 2024

🎉 This PR is included in version 6.0.0-alpha.118 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mcoker mcoker deleted the issue-6522 branch January 7, 2025 16:48
@patternfly-build patternfly-build mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattnolting mattnolting mattnolting approved these changes

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

Assignees

No one assigned

Labels

released on @alpha

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update dependencies for v6

4 participants

@mcoker @patternfly-build @mattnolting @wise-king-sullyman
0