fix(global): pf-global and pf-v5 to pf-v6 updates#6494
Merged
mcoker merged 4 commits intopatternfly:v6from Apr 1, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6494.surge.sh A11y report: https://patternfly-pr-6494-a11y.surge.sh |
srambach
reviewed
Mar 29, 2024
|
|
||
| // Close | ||
| --#{$about-modal-box}__close--ZIndex: var(--#{$pf-global}--ZIndex--2xl); // TODO zindex token | ||
| --#{$about-modal-box}__close--ZIndex: var(--pf-t--global--Zindex--2xl); // TODO zindex token |
Member
There was a problem hiding this comment.
Can probably take the TODO off now?
| --#{$content}--ul--nested--MarginTop: var(--pf-t--global--spacer--sm); | ||
| --#{$content}--ul--nested--MarginLeft: var(--pf-t--global--spacer--sm); | ||
| --#{$content}--ul--ListStyle: var(--#{$pf-global}--ListStyle); // TODO | ||
| --#{$content}--ul--ListStyle: var(--pf-t--global--list-style); // TODO |
| --#{$dual-list-selector}__item-toggle-icon--Rotate: 0; | ||
| --#{$dual-list-selector}__list-item--m-expanded__item-toggle-icon--Rotate: 90deg; | ||
| --#{$dual-list-selector}__item-toggle-icon--Transition: var(--#{$pf-global}--Transition); // need token | ||
| --#{$dual-list-selector}__item-toggle-icon--Transition: var(--pf-t--global--transition); // need token |
Member
There was a problem hiding this comment.
I think this comment can be removed
| // toggle icon | ||
| --#{$jump-links}__toggle-icon--Color: currentcolor; | ||
| --#{$jump-links}__toggle-icon--Transition: var(--#{$pf-global}--Transition); // TODO | ||
| --#{$jump-links}__toggle-icon--Transition: var(--pf-t--global--transition); // TODO |
| --#{$list}--nested--MarginTop: var(--pf-t--global--spacer--sm); | ||
| --#{$list}--nested--MarginLeft: var(--pf-t--global--spacer--sm); | ||
| --#{$list}--ul--ListStyle: var(--#{$pf-global}--ListStyle); // TODO add token? | ||
| --#{$list}--ul--ListStyle: var(--pf-t--global--list-style); // TODO add token? |
Comment on lines
+124
to
+125
| --#{$menu}--m-drilldown__content--TransitionDuration--height: var(--pf-t--global--transitionDuration); // TODO: Update transition with token update | ||
| --#{$menu}--m-drilldown__content--TransitionDuration--transform: var(--pf-t--global--transitionDuration); // TODO: Update transition with token update |
srambach
approved these changes
Mar 30, 2024
Member
There was a problem hiding this comment.
Just silly comments about removing TODO markers.
FABULOUS job! 🐰
|
|
||
| // * Table expandable row | ||
| --#{$table}__expandable-row--Transition: var(--#{$pf-global}--Transition); // TODO: update to token when available | ||
| --#{$table}__expandable-row--Transition: var(--pf-t--global--transition); // TODO: update to token when available |
Contributor
Author
There was a problem hiding this comment.
That would be a great productivity app name!
|
|
||
| // * Table expandable row | ||
| --#{$table}__expandable-row--Transition: var(--#{$pf-global}--Transition); // TODO: update to token when available | ||
| --#{$table}__expandable-row--Transition: var(--pf-t--global--transition); // TODO: update to token when available |
src/patternfly/base/_themes.scss
Outdated
|
|
||
| &.pf-m-transparent-100 { | ||
| background-color: rgba($pf-v5-color-black-1000, .42); | ||
| background-color: rgba($pf-v6-color-black-1000, .42); |
Member
There was a problem hiding this comment.
Do we even still need this file? Is it used for those deprecated components still?
Comment on lines
+124
to
+125
| --#{$menu}--m-drilldown__content--TransitionDuration--height: var(--pf-t--global--transitionDuration); // TODO: Update transition with token update | ||
| --#{$menu}--m-drilldown__content--TransitionDuration--transform: var(--pf-t--global--transitionDuration); // TODO: Update transition with token update |
|
|
||
| // * Menu drilldown list | ||
| --#{$menu}--m-drilldown__list--TransitionDuration--transform: var(--#{$pf-global}--TransitionDuration); // TODO: Update transition with token update | ||
| --#{$menu}--m-drilldown__list--TransitionDuration--transform: var(--pf-t--global--transitionDuration); // TODO: Update transition with token update |
| --#{$modal-box}--BorderRadius: var(--pf-t--global--border--radius--large); | ||
| --#{$modal-box}--BoxShadow: var(--pf-t--global--box-shadow--lg); | ||
| --#{$modal-box}--ZIndex: var(--#{$pf-global}--ZIndex--xl); // TODO use a z-index token | ||
| --#{$modal-box}--ZIndex: var(--pf-t--global--Zindex--xl); // TODO use a z-index token |
| // Panel | ||
| --#{$sidebar}__panel--FlexBasis--base: auto; | ||
| --#{$sidebar}__panel--BoxShadow--base: #{0 pf-size-prem(4px) pf-size-prem(4px) pf-size-prem(-4px) rgba($pf-v5-color-black-1000, .16)}; // TODO NEEDS TOKEN. previous comment:modified so the shadow is only visible on the bottom of the element | ||
| --#{$sidebar}__panel--BoxShadow--base: var(--pf-t--global--box-shadow--md--bottom); // TODO NEEDS TOKEN. previous comment:modified so the shadow is only visible on the bottom of the element |
| // * Toolbar expand all | ||
| --#{$toolbar}__expand-all-icon--Rotate: 0; | ||
| --#{$toolbar}__expand-all-icon--Transition: var(--#{$pf-global}--Transition); // TODO: update when transition is tokenized | ||
| --#{$toolbar}__expand-all-icon--Transition: var(--pf-t--global--transition); // TODO: update when transition is tokenized |
Member
There was a problem hiding this comment.
All done! TODO can be removed.
16 tasks
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.115 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6493