feat(utilities): update uses of color utilities#6492
Merged
mcoker merged 1 commit intopatternfly:v6from Mar 29, 2024
Merged
Conversation
Collaborator
|
Preview: https://patternfly-pr-6492.surge.sh A11y report: https://patternfly-pr-6492-a11y.surge.sh |
mcoker
approved these changes
Mar 29, 2024
Contributor
There was a problem hiding this comment.
Left a couple of comments but they can be follow ups
🚀
| {{/description-list-description}} | ||
| {{#> description-list-description}} | ||
| <time class="pf-v6-u-color-200 pf-v6-u-font-size-sm">Jun 17, 11:02 am</time> | ||
| <time class="pf-v6-u-text-color-subtle pf-v6-u-font-size-sm">Jun 17, 11:02 am</time> |
Contributor
There was a problem hiding this comment.
The timestamp component looks like it would be perfect here
| {{> card-title card-title-text--value="5 Clusters"}} | ||
| {{#> card-body}} | ||
| <i class="fas fa-check-circle pf-v6-u-success-color-100" aria-hidden="true"></i> | ||
| <i class="fas fa-check-circle pf-v6-u-icon-color-status-success" aria-hidden="true"></i> |
Contributor
There was a problem hiding this comment.
This works, but IMO ideally these demos should be updated to use the icon component since it has support for status colors.
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.114 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Apr 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes and updates some places where utility classes of old colors were used.
Fixes #6491