chore(tokens): updated form element spacers to tokens#6464
Merged
mcoker merged 3 commits intopatternfly:v6from Mar 29, 2024
Merged
chore(tokens): updated form element spacers to tokens#6464mcoker merged 3 commits intopatternfly:v6from
mcoker merged 3 commits intopatternfly:v6from
Conversation
Collaborator
|
Preview: https://patternfly-pr-6464.surge.sh A11y report: https://patternfly-pr-6464-a11y.surge.sh |
andrew-ronaldson
approved these changes
Mar 26, 2024
Collaborator
There was a problem hiding this comment.
I think this looks good...🤞
924be92 to
58c810a
Compare
Member
|
This seems to have some differences - the alert is getting taller and then the text aligns oddly And the card is taller than it used to be And form control is definitely off :-( |
srambach
approved these changes
Mar 28, 2024
Member
There was a problem hiding this comment.
I see a teensy shift from before in card and in where the X is on alerts, but it seems to be lined up with the text so afaict it's good!
mcoker
approved these changes
Mar 29, 2024
Collaborator
|
🎉 This PR is included in version 6.0.0-alpha.109 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6363
Only updated TODOs/existing form element vars to tokens. Started to update instances of t-shirt spacers, but that may depend on naming (for example, plain buttons would need a new token added, but does
--pf-t--global--spacer--button--plain--default/--pf-t--global--spacer--button--plain--compactmake sense?). Also using the same spacer on different components could cause different spacing than possibly intended (had placed a spacer on the Text Input Group left/right padding as well as a Drawer close button's padding or margin, and it results in one of them having significant difference than current spacing; couldn't really think of a good name for a new token other than maybe "--enlarged" or "--extra-compact" and such)