fix(menu-toggle): added support for validation/status#6441
fix(menu-toggle): added support for validation/status#6441mcoker merged 2 commits intopatternfly:v6from
Conversation
|
Preview: https://patternfly-pr-6441.surge.sh A11y report: https://patternfly-pr-6441-a11y.surge.sh |
| --#{$menu-toggle}__status-icon--MarginInlineEnd: var(--pf-t--global--spacer--md); | ||
|
|
||
| // Success | ||
| --#{$menu-toggle}--m-success--after--BorderBottomColor: var(--pf-t--global--border--color--status--success--default); |
There was a problem hiding this comment.
Same would apply to warning and danger vars + where they're used:
| --#{$menu-toggle}--m-success--after--BorderBottomColor: var(--pf-t--global--border--color--status--success--default); | |
| --#{$menu-toggle}--m-success--BorderColor: var(--pf-t--global--border--color--status--success--default); |
There was a problem hiding this comment.
d'oh! copy/pasta fail 🤦♂️
There was a problem hiding this comment.
Tis a fine PR it is!
There was a problem hiding this comment.
I am noticing that there isn't as much padding to the right of the caret compared to the other menu toggles, but otherwise looks good!
There was a problem hiding this comment.
Looks good. Definitely a candidate for a focus ring adjustment but that'll come later. 🚀
I was trying to compare the caret spacing too, but decided design could weigh in on that! Can always tweak that later if it bugs anyone. |
|
🎉 This PR is included in version 6.0.0-alpha.105 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Opened #6458 to track that spacing update from #6441 (review) |
fixes #6243